Skip to content

Fix tests namespace pollution from entsoe and remove tests/init#201

Merged
Marenz merged 2 commits into
frequenz-floss:v0.x.xfrom
Marenz:fix-tests-package-pollution
Oct 6, 2025
Merged

Fix tests namespace pollution from entsoe and remove tests/init#201
Marenz merged 2 commits into
frequenz-floss:v0.x.xfrom
Marenz:fix-tests-package-pollution

Conversation

@Marenz
Copy link
Copy Markdown
Contributor

@Marenz Marenz commented Oct 6, 2025 •
edited
Loading

See EnergieID/entsoe-py#447 for details.
Example of the problem:

nox > mypy docs noxfile.py tests
Success: no issues found in 8 source files
nox > pylint src docs noxfile.py tests
************* Module tests
tests/__init__.py:1:0: F0010: error while code parsing: Unable to load file tests/__init__.py:
[Errno 2] No such file or directory: 'tests/__init__.py' (parse-error)

THis also removes the init file, as described in https://github.com/frequenz-io/rnd/issues/170

@Marenz Marenz requested a review from a team as a code owner October 6, 2025 09:06
Copilot AI review requested due to automatic review settings October 6, 2025 09:06
Copilot AI reviewed Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a namespace pollution issue caused by the entsoe-py dependency by restricting its version range to avoid problematic versions that introduce a conflicting tests package.

  • Updated version constraint for entsoe-py dependency from < 0.8.0 to < 0.7.1
  • Added explanatory comment linking to the upstream issue

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions Bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Oct 6, 2025
@Marenz
Fix tests namespace pollution from entsoe
cbc9e53 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz Marenz force-pushed the fix-tests-package-pollution branch from 758dd5f to cbc9e53 Compare October 6, 2025 09:10
@Marenz Marenz added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Oct 6, 2025
florian-wagner-frequenz
florian-wagner-frequenz previously approved these changes Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@florian-wagner-frequenz florian-wagner-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the link describing what's going on and the PR to upstream.
I assume you will unpin it once the fix is merged upstream.

@Marenz
Remove obsolete tests init file
6d87d56 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@github-actions github-actions Bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Oct 6, 2025
@Marenz Marenz changed the title Fix tests namespace pollution from entsoe Fix tests namespace pollution from entsoe and remove tests/init Oct 6, 2025
@Marenz
Copy link
Copy Markdown
Contributor Author

Marenz commented Oct 6, 2025

Updated to also remove the tests/init file to avoid masking similar problems in the future.

https://github.com/frequenz-io/rnd/issues/170

@Marenz
Copy link
Copy Markdown
Contributor Author

Marenz commented Oct 6, 2025

I assume you will unpin it once the fix is merged upstream.

That is def. the plan.

@Marenz Marenz added this pull request to the merge queue Oct 6, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit fd04aa9 Oct 6, 2025
5 checks passed
@Marenz Marenz deleted the fix-tests-package-pollution branch October 6, 2025 09:44
@Marenz
Copy link
Copy Markdown
Contributor Author

Marenz commented Oct 20, 2025

A fixed version https://github.com/EnergieID/entsoe-py/releases/tag/V0.7.6 was released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@cwasicki cwasicki cwasicki approved these changes

@florian-wagner-frequenz florian-wagner-frequenz florian-wagner-frequenz approved these changes

Assignees

No one assigned

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marenz @cwasicki @florian-wagner-frequenz